GH-10090: Add channel adapters for AMQP 1.0 #10445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This just an initial PoC and provides only an outbound channel adapter implementation. I anticipate these features yet:
Thanks |
cppwfs
requested changes
Sep 24, 2025
...qp/src/main/java/org/springframework/integration/amqp/outbound/AmqpClientMessageHandler.java
Outdated
Show resolved
Hide resolved
...qp/src/main/java/org/springframework/integration/amqp/outbound/AmqpClientMessageHandler.java
Show resolved
Hide resolved
...qp/src/main/java/org/springframework/integration/amqp/outbound/AmqpClientMessageHandler.java
Show resolved
Hide resolved
...qp/src/main/java/org/springframework/integration/amqp/outbound/AmqpClientMessageHandler.java
Show resolved
Hide resolved
...qp/src/main/java/org/springframework/integration/amqp/outbound/AmqpClientMessageHandler.java
Show resolved
Hide resolved
...c/test/java/org/springframework/integration/amqp/outbound/AmqpClientMessageHandlerTests.java
Outdated
Show resolved
Hide resolved
cppwfs
approved these changes
Sep 25, 2025
...c/test/java/org/springframework/integration/amqp/inbound/AmqpClientMessageProducerTests.java
Show resolved
Hide resolved
Related to: spring-projects#10090 Spring AMQP now provides the `org.springframework.amqp:spring-rabbitmq-client` library to communicate to RabbitMQ with AMQP 1.0 protocol. * Replace `spring-rabbit` with the `spring-rabbitmq-client` since the latter brings the AMQP 0.9 protocol library as transitive dependency * Introduce an `AmqpClientMessageHandler` based on the `AsyncAmqpTemplate` where its implementation should be for AMQP 1.0, e.g. `org.springframework.amqp.rabbitmq.client.RabbitAmqpTemplate` * This outbound channel adapter can behave as a gateway when `setRequiresReply(true)` * Cover basic `AmqpClientMessageHandler` with integration tests * Document this new feature
…rom RabbitMQ AMQP 1.0 * Fix typos and language in docs and Javadocs * Add tests and docs about new `AmqpClientMessageProducer` * Add `whats-new.adoc` bullet for a new `spring-integration-amqp` feature
…iledException` when exception is bubbled from the downstream flow * Add test for error handling * Add test for batch manual ack * Remove redundant (and dangerous) `@ComponentScan` from the `ManualAckTests`: it does not do anything for the test suite, but is able to see all the `@Configuration` classes in other tests of this package. That may lead to unexpected behavior and failures
artembilan
force-pushed
the
GH-10090
branch
from
7ffeb67 to
4d7b950
Compare
artembilan
changed the title
|
@cppwfs , let me know if you are going to merge this after your next review, or is that OK for me to continue piling related features into this PR. |
cppwfs
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10090
Spring AMQP now provides the
org.springframework.amqp:spring-rabbitmq-clientlibrary to communicate to RabbitMQ with AMQP 1.0 protocol.spring-rabbitwith thespring-rabbitmq-clientsince the latter brings the AMQP 0.9 protocol library as transitive dependencyAmqpClientMessageHandlerbased on theAsyncAmqpTemplatewhere its implementation should be for AMQP 1.0, e.g.org.springframework.amqp.rabbitmq.client.RabbitAmqpTemplatesetRequiresReply(true)AmqpClientMessageHandlerwith integration tests